Inserting a dropdownlist value from a database - PHP

<?php

$db_name="yourdatabasename";// Database name
$conn=mysql_connect("localhost","databaseroot","password") or die("Error");
$db=mysql_select_db($db_name,$conn) or die("Unable to connect");
$databasetable="databasetablename"; // Table name

mysql_select_db("wphm", $conn);
$resultcity = mysql_query ("SELECT DISTINCT city FROM $databasetable ORDER BY city asc");

if (mysql_num_rows ($resultcity)) {
echo "<label>City:</label>\n";
echo "<SELECT name=\"ddcity\" id=\"ddcity\" onchange=\"this.form.submit();\">\n";
echo "<OPTION value=\"\">--choose city--</OPTION>\n";
while ($s1 = mysql_fetch_array ($resultcity, MYSQL_ASSOC)) {
foreach($s1 as $i1){
if($i1 == $_POST['ddcity']){$sel1 = " SELECTED";}
else{$sel1 = "";}
/*echo "<option value='" . $i1 . "'" . $sel1 . ">";
for ($i1 = 1; $i1 <= $_POST['ddcity']; $i1++) echo "&nbsp;&nbsp;";
echo "$s1[city]</option>\n";*/
echo "<option value='" . $i1 . "'" . $sel1 . ">" . $i1 . "</option>";
}
}
echo "</SELECT>\n";
}
?>